Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aliases for Amazon Echo Dot 3 & 4 #1566

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Conversation

Mirabis
Copy link
Contributor

@Mirabis Mirabis commented Mar 14, 2023

Hi,

I kept track of the releases and heard Amazon Echo deices were supported - yay. However, after trying and trying I found out that the IDs are different when not using the official integration. There's a popular unofficial version (free) that is available on HACS but those use a different ID.

I added both the aliases as I have both devices in HA. Repo for custom component is: https://github.com/custom-components/alexa_media_player

@bramstroker
Copy link
Owner

@wranglatang @Mirabis @sockmonkey0223

There are also two other issues created where there are other model ID's referenced.

Let's also resolve that in this PR.

See #1568 and #1569

C78MP8 seem to be model id for Gen3 (In the original PR D91029T)
I cannot find anything in Google for D91029T, so I don't know where you got that model id from @wranglatang.

B7W644 for Gen4 (in the original PR B7W64E)
Only difference here seems to be the color, so B7W644 can be added as alias as well. @Mirabis Can you add that?

@wranglatang
Copy link
Contributor

I just read the Model ID off the bottom of the device but i have recently noticed that when using the unofficial Alexa Media Player integration the model ID's are different. Seems like we have a few different options

Gen 3:

  • D91029T - Bottom of Device
  • ECHO A32DOYMUN6DTXA - Alexa Media Player Integration
  • C78MP8 - Not sure where this has come from

Gen 4:

  • B7W64E - Bottom of Device
  • ECHO A2U21SRK4QGSE1 - Alexa Media Player
  • B7W644 - Not sure where this has come from

@bramstroker bramstroker mentioned this pull request Mar 16, 2023
3 tasks
@sockmonkey0223
Copy link
Contributor

I just read the Model ID off the bottom of the device but i have recently noticed that when using the unofficial Alexa Media Player integration the model ID's are different. Seems like we have a few different options

Gen 3:

  • D91029T - Bottom of Device
  • ECHO A32DOYMUN6DTXA - Alexa Media Player Integration
  • C78MP8 - Not sure where this has come from

Gen 4:

  • B7W64E - Bottom of Device
  • ECHO A2U21SRK4QGSE1 - Alexa Media Player
  • B7W644 - Not sure where this has come from

Here is my Gen 3 Echo DOT Charcoal:

  • C78MP8 - Bottom of device
  • ECHO A1RABVCI4QCIKC - Alexa Media Player

My Gen 4 Echo DOT Glacier White:

  • B7W64E - Bottom of device
  • ECHO A2U21SRK4QGSE1 - Alexa Media Player

@wranglatang
Copy link
Contributor

Hmm okay, so looks like different models for different colours -_- Maybe its best to just have the model as Gen3 & Gen4 and then the user just selects that in the GUI or code.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Mirabis
Copy link
Contributor Author

Mirabis commented Mar 16, 2023

  • My Black Echo Dot 4 (B7W64E) shows up as A2U21SRK4QGSE1 in the integration;
  • @sockmonkey0223's Glacier White (B7W64E) Echo Dot 4 shows up as A2U21SRK4QGSE1 in the integration.

Those are identical, so most likely the model doesn't change for colour but for features. The version with clock has B7W644, other variants may have other IDs as well. Echo Plus Gen 2 reports as ALEGCNGL9K0HM for instance.

@bramstroker I've updated the PR for the specified issues and double checked the ID's in the other repo. More aliases should be added later on, but I do not have all the device types nor time (at the moment) to dig through the logs people post on the custom integration.

@bramstroker
Copy link
Owner

Thanks. Looks fine like this. Think we can merge.
Btw you don't have to touch supported_models.md next time. That will be autogenerated, so you can save time.

@bramstroker bramstroker merged commit 084edec into bramstroker:master Mar 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4442651461

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 98.34%

Files with Coverage Reduction New Missed Lines %
custom_components/powercalc/discovery.py 2 98.48%
Totals Coverage Status
Change from base Build 4399360199: 0.003%
Covered Lines: 2785
Relevant Lines: 2832

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants