Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests and MyPy checks to latest HA version 2024.10.2 #1997

Merged
merged 9 commits into from Jan 13, 2024

Conversation

bramstroker
Copy link
Owner

@bramstroker bramstroker commented Jan 12, 2024

See KapJI/homeassistant-stubs#397 for mypy. Need to wait for next version of homeassistant-stubs, which resolves syntax error in the linting job.

Also seems to be a performance regression from HA 2023.9.3 -> 2023.10.0.
Previously full test suite would finish in ~5 seconds, in HA upgrade it takes double ~10 seconds all of a sudden.
Might need investigation.

Upgraded python packages after which the peformance degradation occurs after poetry update:

  • Removing colored (1.4.4)
  • Updating cryptography (41.0.3 -> 41.0.4)
  • Updating awesomeversion (22.9.0 -> 23.8.0)
  • Updating coverage (7.3.0 -> 7.3.1)
  • Updating orjson (3.9.2 -> 3.9.7)
  • Updating homeassistant (2023.9.3 -> 2023.10.0)
  • Updating numpy (1.23.2 -> 1.26.0)
  • Updating pytest-aiohttp (1.0.4 -> 1.0.5)
  • Updating sqlalchemy (2.0.15 -> 2.0.21)
  • Updating syrupy (4.2.1 -> 4.5.0)
  • Updating homeassistant-stubs (2023.9.3 -> 2023.10.0)
  • Updating pytest-homeassistant-custom-component (0.13.57 -> 0.13.63)

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Qodana Community for Python

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7515170297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7500963936: 0.0%
Covered Lines: 3563
Relevant Lines: 3563

💛 - Coveralls

@bramstroker bramstroker changed the title Upgrade tests to latest HA version Upgrade tests and MyPy checks to latest HA version 2024.10.2 Jan 12, 2024
Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bramstroker bramstroker merged commit cc11c8b into master Jan 13, 2024
13 checks passed
@bramstroker bramstroker deleted the feat/update-ha-test branch March 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant