Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding I002741 #2065

Closed
wants to merge 1 commit into from
Closed

adding I002741 #2065

wants to merge 1 commit into from

Conversation

noob4722019
Copy link
Contributor

Device information

Home Assistant Device information

Checklist

  • I have created a single PR per device. When you have multiple submissions please create separate PR's.
  • For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
  • For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bramstroker
Copy link
Owner

@noob4722019 First of all thanks for your efforts and the PR.

There are a few problems with the measurements.

  • The precision is only 0.5W. Almost all measurements in Powercalc have a precision of 0.1W, so that's preferrable quality wise.
  • There are outliers, especially visible at brightness level 1, where the smartplug reported 11 watt. This could potentially be caused by the smartplug not reporting new power values frequent enough. And thus still reporting the power when the light was fully on. Also see csv visualisation below.

Do you have any options to redo measurements with another smartplug and see if we can get better results?
You don't have to do hs.csv yet. That one can be done when we have better results for color_temp.csv.

Screenshot 2024-02-23 at 13 43 08

When you update the PR all the csv files needs to be gzipped (compressed). The measure tool has that option so you should enable that. Only the .csv.gz files needs to de commited in the PR, the .csv files needs to be removed.

@noob4722019
Copy link
Contributor Author

Please note, per #2036, still running into below issues when adding these templates to my install at %HA%/homeassistant-powercalc/custom_components/powercalc/data/genio/I002741

2024-02-23 23:56:58.364 ERROR (MainThread) [custom_components.powercalc.config_flow] No lookup file found for mode: color_temp
2024-02-23 23:56:58.542 ERROR (MainThread) [custom_components.powercalc.config_flow] No lookup file found for mode: color_temp
2024-02-23 23:56:58.715 ERROR (MainThread) [custom_components.powercalc.config_flow] No lookup file found for mode: color_temp

@noob4722019
Copy link
Contributor Author

No worries. I have a few other plugs on hand, let me re-run the tests. 🤞

@noob4722019 noob4722019 closed this by deleting the head repository Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants