Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lidl HG06106C and HG07834C #662

Merged
merged 5 commits into from Apr 7, 2022

Conversation

roscarraig
Copy link
Contributor

Two variants of the Lidl E27 Livarno Lux E27 RGB Bulb

@bramstroker
Copy link
Owner

Thanks for the PR.

The non gzipped files must be removed.

Also check the failed job there is a hs.gz file which contains some 0 values. You can correct there by looking at the nearby values and do some guesstimation.

@roscarraig
Copy link
Contributor Author

roscarraig commented Apr 6, 2022

Sure, cheers. To be clear by non-gzipped do you include the model.json files? I know I removed the uncompressed csvs as directed.
Update: Argh. I messed up on that. Updating.
I've got a draft of the updated hs.gz with interpolated values and I'll be amending the commit in the next while.

@bramstroker
Copy link
Owner

Thanks. model.json files must remain.
There is one issue:

Checking lidl/HG07834C/color_temp.csv.gz
Invalid
Error: Max brightness level 31 is less than 250. Measurements probably not finished completely

Seems this file has stopped at 31. Could you check that. Need to resume / redo measurements when this is the case.

@roscarraig
Copy link
Contributor Author

Running the color_temp collection from scratch on HG07834C, will update once it completes

@bramstroker bramstroker added the new model Support for new light model label Apr 7, 2022
@roscarraig
Copy link
Contributor Author

I swear I checked for non-zero values (goes to look).

@bramstroker
Copy link
Owner

There is one row with 0 reading. Could you correct that one than we are ready to merge

@bramstroker
Copy link
Owner

My comment crossed yours lol

@bramstroker bramstroker merged commit 0aa3700 into bramstroker:master Apr 7, 2022
@roscarraig roscarraig deleted the feature/lidl/light branch April 7, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new model Support for new light model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants