add_support_for_IKEA_LED1545G12 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. It's fine to leave the entry in const.py. Maybe the Hue bridge will correctly identify things in the future, and than we don't have to do any modifications. |
|
@CM000n |
|
And one more important thing. I'm sure that standby power draw is greater than 0W, so I can suggest to set it to 0.45W (it must be close to LED1546G12) or measure correctly real power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bramstroker , here is a LUT file for an Ikea lamp of mine. I have also added the lamp name to the lookup in Const.py. But to be honest, at least for me, the lamp is only displayed by Hue as an empty string without a name.
Should I still leave the lookup in Const.py, or would you prefer me to leave it out completely?