fix(fastlane): ENG-5249 android app center release mode #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android build number for is important for not only the Google Play Store but also if you are installing subsequent versions of a mobile application. The build number must be incremental compared to the previous version installed. Adding the conditional to release mode to always increment the build nubmer based on the previously released version.
crherman7
commented
May 2, 2024
| @@ -2213,7 +2213,8 @@ | |||
| tslib "^2.0.0" | |||
|
|
|||
| "@brandingbrand/code-plugin-local@link:./apps/react-native/.coderc/plugins/plugin-local": | |||
| version "0.0.1" | |||
| version "0.0.0" | |||
There was a problem hiding this comment.
This is leftover incidentals from dependabot.
NickBurkhartBB
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Android build number for is important for not only the Google Play Store but also if you are installing subsequent versions of a mobile application. The build number must be incremental compared to the previous version installed.
Adding the conditional to release mode to always increment the build number based on the previously released version.
Issue ticket number and link
Ticket
Type of change
Please delete options that are not relevant.
Test Plan
yarn testChecklist before requesting a review