This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9aa8ddc
commit a1b5273
Showing
1 changed file
with
8 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @bweissbart, looks like the latest version you've released is version 4.0.0. Is that correct? I am a bit confused why there is a reference of of version 5.0.0 on npm?
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linamm - we do have a 5.0.0 release but it's only compatible with RN 0.60.0 and above.
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, Ok, thanks for confirming this.
From this release page, https://github.com/brandingbrand/react-native-leanplum/releases,
I can only see version 4. Can you advise me how to see the diff between 4.0.0 and 5.0.0?
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon closer inspection, it appears that we had a misfire from semantic-release. 4.0 contains the auto-linking changes and SDK updates, and 5.0 should have not been created. I removed the v5 release, updated the README, and edited the v4 release: https://github.com/brandingbrand/react-native-leanplum/releases/tag/v4.0.0
Thanks for bringing this to our attention!
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um... we are using react-native 0.59.10 and v5.0.0 has caused us a bit of an issue. then we reverted to v4.0.0 and it is working fine.
By editing the v4.0.0, will that mean our issue will come back now?
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, it is v4.0.1, that should be fine then. Many thanks!
a1b5273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#34