Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for python 3.12 #259

Merged
merged 4 commits into from Oct 7, 2023
Merged

Changes for python 3.12 #259

merged 4 commits into from Oct 7, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jul 21, 2023

@cdce8p cdce8p mentioned this pull request Jul 21, 2023
32 tasks
@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 30, 2023

@brandon-rhodes Not sure if you've seen it. This would make the library ready for 3.12, the first release candidate is scheduled for tomorrow already.

@brandon-rhodes
Copy link
Owner

Yes, I did see it — but have been a bit busy and, obviously, haven't responded yet. I'll try to schedule some time to work on PyEphem before the 3.12 October release, though!

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2023

I saw the failed workflow for macos-10.15. That's likely because the runner image name changed to macos-12 / macos-latest. I've updated it, the other images which also were getting old, and the basic actions to their newest releases.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
https://github.com/brandon-rhodes/pyephem/actions/runs/6399268653/job/17374304136

@brandon-rhodes
Copy link
Owner

I saw the failed workflow for macos-10.15. …

Thank you, I hadn't known whether it was a transient problem stalling Mac builds, or something more serious. Hopefully the builds will succeed this time!

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2023

Hopefully the builds will succeed this time!

Seem like they are all good 🎉

@brandon-rhodes brandon-rhodes merged commit 3e5bd8c into brandon-rhodes:master Oct 7, 2023
4 checks passed
@cdce8p cdce8p deleted the python-312 branch October 7, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants