-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclusion for new clojure.core/boolean?
var
#39
Conversation
Clojure 1.9 adds several new predicate functions to `clojure.core`, including `boolean?`. Compiling Fipp with the 1.9.0-alpha7 prints this warning: `WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: fipp.visit, being replaced by: #'fipp.visit/boolean?`. Excluding `boolean?` removes the warning.
@@ -1,5 +1,6 @@ | |||
(ns fipp.visit | |||
"Convert to and visit edn structures." | |||
(:refer-clojure :exclude [boolean?]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this on CLJS? I'm not sure if multiple :refer-clojure
forms is valid. Even if it works, I think I'd prefer to put the feature expression on the individual entry in the vector, rather than have duplicate clauses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, presumably, CLJS will have boolean?
now too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I saw on Slack that all of the new core predicates will be added to CLJS soon.
I'll wait for Clojure/ClojureScript 1.9 release to cut a new version. Thanks! |
Merged in b42d04a -- Thanks! |
Deployed release 0.6.6 to clojars |
Fixes Clojure 1.9 support - see brandonbloom/fipp#39
Future finders of this issue, if you are getting the warning about {:user {:plugins [[venantius/ultra "0.4.0"]]}} If you upgrade to the latest version of A way to solve similar problems in the future is to run |
Clojure 1.9 adds several new predicate functions to
clojure.core
, includingboolean?
. Compiling Fipp with the 1.9.0-alpha7 prints this warning:Excluding
boolean?
removes the warning.