Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusion for new clojure.core/boolean? var #39

Closed
wants to merge 2 commits into from
Closed

Add exclusion for new clojure.core/boolean? var #39

wants to merge 2 commits into from

Conversation

AdamFrey
Copy link
Contributor

Clojure 1.9 adds several new predicate functions to clojure.core, including boolean?. Compiling Fipp with the 1.9.0-alpha7 prints this warning:

WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: fipp.visit, being replaced by: #'fipp.visit/boolean?

Excluding boolean? removes the warning.

Clojure 1.9 adds several new predicate functions to `clojure.core`, including `boolean?`. Compiling Fipp with the 1.9.0-alpha7 prints this warning:
`WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: fipp.visit, being replaced by: #'fipp.visit/boolean?`. Excluding `boolean?` removes the warning.
@@ -1,5 +1,6 @@
(ns fipp.visit
"Convert to and visit edn structures."
(:refer-clojure :exclude [boolean?])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this on CLJS? I'm not sure if multiple :refer-clojure forms is valid. Even if it works, I think I'd prefer to put the feature expression on the individual entry in the vector, rather than have duplicate clauses.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, presumably, CLJS will have boolean? now too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I saw on Slack that all of the new core predicates will be added to CLJS soon.

@brandonbloom
Copy link
Owner

brandonbloom commented Jun 16, 2016

I'll wait for Clojure/ClojureScript 1.9 release to cut a new version. Thanks!

@brandonbloom
Copy link
Owner

Merged in b42d04a -- Thanks!

@brandonbloom
Copy link
Owner

Deployed release 0.6.6 to clojars

dhruvbhatia added a commit to dhruvbhatia/puget that referenced this pull request Aug 23, 2016
Fixes Clojure 1.9 support - see brandonbloom/fipp#39
@roryokane
Copy link

roryokane commented Oct 31, 2019

Future finders of this issue, if you are getting the warning about #'fipp.visit/boolean? in a newly-created Leiningen project and you don’t know which part of your code is causing this, check your global ~/.lein/profiles.clj file. You might be depending on an old version of venantius/ultra, like this:

{:user {:plugins [[venantius/ultra "0.4.0"]]}}

If you upgrade to the latest version of venantius/ultra, this will upgrade the version of fipp it depends on via mvxcvi/puget, fixing the warning-causing code.

A way to solve similar problems in the future is to run lein deps :tree, which prints a list of your project’s transitive dependencies, including the ones pulled in by your Leiningen profile. That’s how I found that venantius/ultra’s dependency on fipp was through mvxcvi/puget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants