Upload div elements changed to <input/> type of 'file' elements #11 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload div elements changed to <input/> type of 'file' elements
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good, but let me preview this one once I am at my PC. |
|
@Halim-Shams any way the inputs could be visible, instead of hidden? And replce the divs? |
|
Nevermind, I see what you were doing. hidden inputs with a for attribute. I included these changes in the newest PR. |
|
Hey @brandonbyr4 was somthing wrong with my pr that you closed it? |
|
I thought it got squashed into the next merge, but looks like there was conflicts. Check the conflicts. |
|
@brandonbyr4 did you run it locally to see where is the problem? I run it locally and there was no problem at all. |
brandonbyr4
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey i just changed the divs to type of 'file'