Some clean up in get quasiquoter #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-leapyear
force-pushed
the
chinn/cleanup
branch
from
6fde3a7
to
bb5d2f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 12 12
Lines 473 473
Branches 21 21
=======================================
Hits 412 412
Misses 52 52
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
Separate the logic for "what function(s) should be called at runtime" from "how should the function(s) be applied wrt subsequent functions". Works a lot more nicely with the new NonEmpty types