Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getFieldOr #10

Closed
brandonchinn178 opened this issue Jul 24, 2022 · 0 comments · Fixed by #14
Closed

Add getFieldOr #10

brandonchinn178 opened this issue Jul 24, 2022 · 0 comments · Fixed by #14
Labels
good first issue Good for newcomers

Comments

@brandonchinn178
Copy link
Owner

It's a common idiom to do something like fromMaybe def <$> getField "field"; let's just add this common case. No need to add getFieldOrWith/getFieldsOr/getFieldsOrWith variants.
@brandonchinn178 brandonchinn178 added the good first issue Good for newcomers label Jul 24, 2022
rvarago added a commit to rvarago/toml-reader that referenced this issue Jul 28, 2022
@rvarago
Add 'getFieldOr' helper
ca65967 
This small helper is meant to handle the case where there's
a sensible default value for a potentially missing key.

Resolves brandonchinn178#10
@rvarago rvarago mentioned this issue Jul 28, 2022
Merged
rvarago added a commit to rvarago/toml-reader that referenced this issue Jul 29, 2022
@rvarago
Add 'getFieldOr' helper
5018c0d 
This small helper is meant to handle the case where there's
a sensible default value for a potentially missing key.

Resolves brandonchinn178#10
rvarago added a commit to rvarago/toml-reader that referenced this issue Jul 29, 2022
@rvarago
Add 'getFieldOr' helper
922218d 
This small helper is meant to handle the case where there's
a sensible default value for a potentially missing key.

Resolves brandonchinn178#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'getFieldOr' helper rvarago/toml-reader
1 participant
@brandonchinn178