Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many simultaneously provided input parameters #4

Open
brandondube opened this issue Aug 14, 2022 · 0 comments
Open

Too many simultaneously provided input parameters #4

brandondube opened this issue Aug 14, 2022 · 0 comments

Comments

@brandondube
Copy link
Owner

The definition for the simple Lyot coronagraph is:

class LyotCoronagraphSingleDM:
    def __init__(self, Nmodel, Npup, Nlyot, Nfpm, Nimg, Dpup, fpm_oversampling, image_oversampling, rFPM, wvl0, fno, data_root, ifn_fn, iwa, owa, start_az, end_az):

which is 16 or so parameters given at once. This is too many for users to not fry their brains. Without thinking too hard, this can be divided in 3 or 4 by breaking up the specification for the pupil, FPM, lyot stop, and final image. Then the definition of a Lyot coronagraph might look like:

class LyotCoronagraphSingleDM:
    def __init__(self, input_pupil, fpm, lyot_stop, final_image):

This seems much simpler, and the various chunks are like legos that can be reused in other coronagraph models

Point designs are great for facilitating discussion, but let's discuss more thoroughly before "finishing" any particular implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant