Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Uploading files without an extension is not supported #37

Closed
scribu opened this issue Mar 4, 2014 · 2 comments · Fixed by #39
Closed

Uploading files without an extension is not supported #37

scribu opened this issue Mar 4, 2014 · 2 comments · Fixed by #39
Assignees
@codeguy
Labels
bug

Comments

@scribu
Copy link

scribu commented Mar 4, 2014

On Linux and OS X, it's perfectly normal to have plain text files without any extension.

But if I upload a file named todo, the final name will be todo. (with a dot at the end).

This is due to the getNameWithExtension() method, which always appends a dot.
@codeguy
Copy link
Contributor

codeguy commented Mar 4, 2014

Thanks! I'll get this fixed.

@codeguy codeguy added the bug label Mar 4, 2014
@codeguy codeguy self-assigned this Mar 4, 2014
Sentence added a commit to Sentence/Upload that referenced this issue Mar 13, 2014
@Sentence
Uploading files without an extension is now supported
777105a 
* brandonsavage#37
@Sentence Sentence mentioned this issue Mar 13, 2014
Merged
@Sentence
Copy link
Contributor

Fixed in #39 and tested on Linux, and working fine with this tiny update.
Now working on Windows too, but the saving method was good at the "past", only the name property was wrong with the dot.

Best regards!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codeguy codeguy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uploading files without an extension is now supported Sentence/Upload
3 participants
@codeguy @scribu @Sentence