Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should provide flags for redis 6 #51

Open
TheCycoONE opened this issue Jun 29, 2020 · 2 comments
Open

Should provide flags for redis 6 #51

TheCycoONE opened this issue Jun 29, 2020 · 2 comments

Comments

@TheCycoONE
Copy link

TheCycoONE commented Jun 29, 2020

I've noticed that the list of flags returned in the 7th value of COMMAND for cl.throttle in redis 6.x is empty. I think @Write and @fast apply.

This may be related to issues I'm having with redis-cell and lettuce on redis 6, but I'm not sure: redis/lettuce#1327

I'm not able to determine from the documentation what the new flag list is; so if anyone knows that would be helpful; otherwise I'll update this ticket when I find out:

 72) 1) "cl.throttle"
     2) (integer) -1
     3) 1) write
     4) (integer) 0
     5) (integer) 0
     6) (integer) 0
     7) (empty array)
@TheCycoONE TheCycoONE changed the title Should provide command flags for redis 6 Should provide flags for redis 6 Jun 29, 2020
@brandur
Copy link
Owner

brandur commented Jul 4, 2020

Interesting — I hadn't taken much of a look at Redis 6 yet, and this is the first time I've seen these flags.

There's no documentation about them in COMMAND, but they do appear in the example run near the bottom of the page. They do get a brief mention in code that suggests they're used for ACL categorization.

I'm not sure there's much that can be done for redis-cell though. The exported CreateCommand API from Redis for Modules still only takes the original arguments, and I couldn't find a new version of it. I suspect that this is a relatively new feature that is not supported for Redis Modules yet, and not even well-described in the core yet.

@TheCycoONE
Copy link
Author

Yes, I noticed due to the linked bug in lettuce handling empty arrays, but wasn't able to find more information. I originally confused them with the flags under 3 when I opened the ticket; and backtracked when I found you were already providing those and it didn't help.

There's some mention of a new module api in an early announcement about 6 but I couldn't find anything about that either. I'll ask around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants