Better handling of chunks when decoding streaming data. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a test generating lots of small chunks in the encoding. The idea is to stress this part of the code to make bugs easier to spot. - Stop reading past input in SnappyDecompressor on chunk boundary. - Copy buffer into correct inidex of partially created scratch on chunk boundary. - Reset _scratchLength after use on chunk boundary.
rodo-r2r
force-pushed
the
rodo/ChunkStressTest
branch
from
cb0d3da
to
5f03323
Compare
rodo-r2r
changed the title
|
Hi, I'm evaluating this library as a replacement for our use of Snappy.NET (for use on .NET Core). I'm pretty sure the build failure above isn't related to any changes I've made here. |
brantburnett
approved these changes
Nov 2, 2020
|
The build failure is a result of a problem in the GitHub action when the PR is from a fork, ignoring and merging. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test generating lots of small chunks in the encoding.
The idea is to stress this part of the code to make bugs easier to spot.
As a result three bugs were fixed: