Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Android based watch support #282

Open
gtr33m opened this issue Nov 6, 2018 · 14 comments
Open

Feature request: Android based watch support #282

gtr33m opened this issue Nov 6, 2018 · 14 comments

Comments

@gtr33m
Copy link

gtr33m commented Nov 6, 2018

I have an amazfit Stratos which is Android 5.1 based with a 320x300 pixel resolution. The app installs and works with a bit of tweaking of the fonts, however the title bar of an individual barcode is too large and takes up too much of the screen. Could you please include an optimisation for a smaller screen?

Thanks

@brarcher
Copy link
Owner

brarcher commented Nov 6, 2018

Trying to install the app to a watch simulator it says that the app does not declare 'uses-feature watch', and thus will not install. Are you modifying the application to install on your watch, or are forcing the install some other way?

I've not considered the use case of using a watch for this application. Supporting a watch requires a separate APK specially for the watch, from what I understand. Supporting a watch is fine, though I do not have one myself so I do not have much incentive. I'd gladly accept contributions which support a watch in a maintainable way.

@gtr33m
Copy link
Author

gtr33m commented Nov 6, 2018 via email

@brarcher
Copy link
Owner

brarcher commented Nov 7, 2018

I actually just installed the APK directly using adb, and it installed fine, and runs without crashing.

Hm. Maybe Android Studio prevented me from installing the APK on the simulator, but doing it with adb directly works fine. I expect that the Play store would be similar, in that it would restrict it. I do not think that F-Droid supports watches (link). Probably the only way to do it without modifying the app is to side load it with adb.

I tried to access the photos, but they are links to Drive. I requested permission to see the pictures. It may be easier to drag/drop them into the comment box on Github, if that is possible.

I'm happy to donate, but unfortunately not enough to get you a watch to play with

lol, that is fine. (:
If there is someone out there who is interested and has the ability to contribute a change, I'd be happy to review it.

So, asking about the use case, what happens when you are at the grocery store and you need to give the clerk your card? I usually hand over my phone and they scan it. Would you be taking off your watch and giving it to them, trying to reach over and scan the watch, or something else? How would that work?

@gtr33m
Copy link
Author

gtr33m commented Nov 7, 2018 via email

@gtr33m
Copy link
Author

gtr33m commented Nov 7, 2018 via email

@gtr33m
Copy link
Author

gtr33m commented Nov 7, 2018 via email

@gtr33m
Copy link
Author

gtr33m commented Nov 7, 2018 via email

@brarcher
Copy link
Owner

brarcher commented Nov 8, 2018

Ah, OK. You explanation of what the device helps make more sense. Namely, it is not a Wear OS device after all.

Are you able to build the code? If so, could you try the following to see if it better reduces the header:

The following two lines in loyalty_card_view_layout.xml control the height of the title bar when displaying a barcode:

                android:layout_marginTop="?actionBarSize"
                android:layout_marginBottom="?actionBarSize"

If you change them to something else, for example the following:

                android:layout_marginTop="10dp"
                android:layout_marginBottom="10dp"

You should see the title bar decrease in size. On my emulator it went from:

screenshot_1541651452

to

screenshot_1541651390

If that gets what you are hoping for, then success! A setting for that field could be created, that way you could configure it instead of it being fixed. Let me know if the suggested change gets you what you need.

@brarcher
Copy link
Owner

brarcher commented Nov 8, 2018

Also, do you mind if I put your pictures into the thread for reference? You listed a barcode in one picture, and I want to be sure its value is not sensitive.

@gtr33m
Copy link
Author

gtr33m commented Nov 8, 2018 via email

@gtr33m
Copy link
Author

gtr33m commented Nov 8, 2018 via email

@brarcher
Copy link
Owner

brarcher commented Nov 8, 2018

Here are the pictures you posted:

20181106_183047
20181106_183040
20181106_183109
20181106_183057

@brarcher
Copy link
Owner

brarcher commented Nov 8, 2018

Is there a setting that sets the default font size for each text field as well?

The default value for the setting are in settings.xml under <!-- Default values -->. That only is used when the app loads for the first time. To use the defaults from that file again you will need to wipe the app data.

@alexanderadam
Copy link

For Garmin there's already "Barcode Wallet" but it cannot sync anything with loyalty card locker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants