Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to lock screen orientation #128

Merged
merged 3 commits into from Jul 17, 2017
Merged

Add option to lock screen orientation #128

merged 3 commits into from Jul 17, 2017

Conversation

brarcher
Copy link
Owner

@brarcher brarcher force-pushed the lock-orientation branch 2 times, most recently from 49277b1 to 0785b5d Compare July 17, 2017 01:19
Even with passing a bundle with the layout ID sometimes
some users will encounter a situation where the _layout
variable is null. To avoid further issues, creating a
class for each intro slide, so the layout is encoded
into the class itself.
When passing a phone to a clerk to scan the barcode, if the
phone is rotated and the screen reloads it can be bothersome
or confusion. To avoid this situation, a new option is
added to lock the screen.

A menu icon is now added which defaults as unlocked. When
touched the app sets its orientation to the "natural" orientation
of the device. When touched again the sensor dictates the
orientation of the device.
@brarcher brarcher merged commit bf60976 into master Jul 17, 2017
@brarcher brarcher deleted the lock-orientation branch July 17, 2017 01:32
@brarcher
Copy link
Owner Author

Hi @arno-github, @lgasp, @techwebpd, @Clonewayx, @pbeckmann, @airon90 and @PanderMusubi:

This request adds some strings which are used in a feature which locks the screen orientation. This is to help prevent the screen from rotating when handing the phone to a clerk to scan a barcode.

The strings are marked with:

<!-- NEEDS TRANSLATED -->

If any are interested in updating translations, please create a merge request with the changes, or attach an updated file and I'll add it.

Thanks!

@PanderMusubi
Copy link

Could you please set up a translation project on Transifex or other translation website? In that way, translations will go much quicker and can be made an reviewed in a more efficient way.

@brarcher
Copy link
Owner Author

I've setup a project here: https://www.transifex.com/na-243/loyalty-card-locker/dashboard/

I'm not sure what needs to be done to add someone who can contribute a translation. Do I need to have your email address to add you?

@PanderMusubi
Copy link

I just requested to become a translator. Think you just have to approve that. Perhaps it is also possible for you to add translators. Probably best is to notify all translaters to go there and also request access.

@brarcher
Copy link
Owner Author

I've accepted your request to join. In the future when new strings are added, is all I need to do is update the English strings on the site, and everyone will be notified automatically? Then, before I make a release just take the most recent translations from the site and commit them?

@PanderMusubi
Copy link

Notification depends on how translaters have configured this in Transifex. However, more people can make translations in this way.

Yes, before each release, simple used the latest version from Transifex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants