Make interface non-blocking #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convenience of the current API is preserved with the `StepFuture::wait` function. Otherwise, this commit introduces a significant amount of complexity. I think that's worth it, given the new capability. Especially as I don't know how to do any better right now, and since this is bound to get _much_ better (both for the user and in the implementation), once the embedded ecosystem grows sufficient support for async/await.
hannobraun
force-pushed
the
non-blocking
branch
from
0e273d7
to
84c7cf3
Compare
This might not be necessary right now, but as more futures and state enums are added for other operations, the `driver` module is bound to become overloaded.
hannobraun
force-pushed
the
non-blocking
branch
from
84c7cf3
to
d41207b
Compare
This doesn't seem like much of a restriction, given what `StepMode` is, and all the generated types derive it. This is going to make some custom future code more straight-forward to implement.
hannobraun
force-pushed
the
non-blocking
branch
from
d41207b
to
0f59c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked on #54 and #56. Requires a rebase once those are merged.
As the title says, this PR makes the interface non-blocking (more explanation in the commit messages). Also contains some clean-ups that can stand on their own. I plan to break those out into separate pull requests for easier review, once the pull requests this is blocked on are merged.
This adds quite a bit of complexity, but I think it's worth it (or rather, non-optional). A lot of this can get cleaned up significantly once we can use async/await, but that requires more support in the embedded ecosystem. There's some movement there, from what I hear, but all of it is a bit too tenuous to block this pull request, in my opinion.
List of things to do after merging this:
Close #5