Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self custody available field to get wallet endpoint #2287

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Jan 10, 2024

Summary

This PR adds the self custody available field to get wallet endpoint.

The endpoint should the below response with the new selfCustodyAvailable field.

{
  "paymentId": "af5f35a5-1809-4e73-91c4-59b8dbe3a42f",
  "walletProvider": {
    "id": "",
    "name": "brave"
  },
  "altcurrency": "BAT",
  "publicKey": "485c991e35fea0a174786eb9062a76ba6aa7c8bedf1d438a200205475f73db4f",
  "selfCustodyAvailable": {
    "solana": true
  }
}

this is a map of providers, currently we only have one Solana.

Please see the spec in the linked issue for more detail.

resolves 168

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

Copy link

The following commits were not verified:
3dd7aeb (unsigned)
4a65141 (unsigned)

@clD11 clD11 merged commit 875466d into master Jan 10, 2024
12 checks passed
@clD11 clD11 deleted the sol-self-custody branch January 10, 2024 21:27
@clD11 clD11 mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants