Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change request_id to disallow null and update index #2506

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented May 9, 2024

Summary

This PR updates the time_limited_v2_order_creds_unique constraint on the time_limited_v2_order_creds table, thus allowing credentials for multiple unique batches within the same period, which is necessary for Multi Device Refresh.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@@ -0,0 +1 @@
ALTER TABLE time_limited_v2_order_creds ALTER COLUMN request_id SET NOT NULL;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment of writing, there have been no rows with request_id NULL in the table (both Staging and Production).

@pavelbrm pavelbrm marked this pull request as ready for review May 9, 2024 11:01
@pavelbrm pavelbrm self-assigned this May 9, 2024
@pavelbrm pavelbrm changed the title feat: change request_id to disallow null and change index feat: change request_id to disallow null and update index May 9, 2024
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! there is a race that this PR in isolation would expose us to - however the plan as I understand it is to deploy this alongside #2522 where it is fixed

@pavelbrm
Copy link
Contributor Author

lgtm! there is a race that this PR in isolation would expose us to - however the plan as I understand it is to deploy this alongside #2522 where it is fixed

Yes, this and #2522, as well as other related PRs are all planned to go in one release, therefore the risk of the race is minimal if not zero.

@pavelbrm pavelbrm merged commit becfddf into master May 29, 2024
12 checks passed
@pavelbrm pavelbrm deleted the mdr-01 branch May 29, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants