-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change request_id to disallow null and update index #2506
Conversation
@@ -0,0 +1 @@ | |||
ALTER TABLE time_limited_v2_order_creds ALTER COLUMN request_id SET NOT NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment of writing, there have been no rows with request_id
NULL
in the table (both Staging and Production).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! there is a race that this PR in isolation would expose us to - however the plan as I understand it is to deploy this alongside #2522 where it is fixed
Summary
This PR updates the
time_limited_v2_order_creds_unique
constraint on thetime_limited_v2_order_creds
table, thus allowing credentials for multiple unique batches within the same period, which is necessary for Multi Device Refresh.Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan