Regress Puma to 3.10 to fix “no implicit conversion of nil into String”

[lgebhardt]

Getting “no implicit conversion of nil into String” messages from puma. Looks like this is an issue introduced in 3.11 per puma/puma#1483, puma/puma#1502

I'm not entirely sure it's causing a real issue, but it is a nuisance. I propose we regress to 3.10 until this is fixed.

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Tagged reviewers.

Test Plan:

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions

Security:

• No raw SQL -- Always prefer ActiveRecord query helpers (more info on StackOverflow)
• XSS is mitigated -- Avoid html_safe and raw; escape untrusted content from users and 3rd party APIs (Rails XSS guide and OWASP XSS Prevention Cheat Sheet)

[mixonic]

@lgebhardt I think this may be fixed by 3.11.2, via puma/puma@acb709b which was referenced on those tickets. I'll try it out.

[mixonic]

So I expected this fix would speed up the server since I believe it is part of SSL negotiation failing. It indeed fixed performance issues with the server to either upgrade or downgrade 🎉 Good news.

v3.11.2 still logs an error Error reached top of thread-pool: EOFError (EOFError):

Thus I suggest shipping this regression of the version instead of the upgrade.

[ayumi]

🍉