-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigation: Easylist audit: Unexpected direct exceptions & protocol filters #14
Comments
Thanks EasyList is in need of an audit. Also if we can do things by still getting updates. I could help with combining a blacklist of rules to filter out before we use easylist. |
Fantastic @bbondy thanks! My goal is to have this knocked out before 1.0 - I think it's workable. I'm noticing two major things - 1. Quick repro example for showing these exceptions directly made in Easylist. Here's a quick method to repro... In Chrome:
I see a lot of ads display in Chrome, and I also see a lot of ad domains in the Exceptions list (windows 10)...Many more examples so far. Then, compare against dev tools in Brave. We block a ton of the exceptions, but I can see a couple we should flag (and will). An audit will be really healthy, and I'm going to begin dumping the exceptions that I'm investigating in the comment that will follow this one. That's awesome about the blacklist too. Confident we'll be able to knock this out. 2. Applying Easylist Websocket Filters in Brave
|
Note: This list will be added to, as I continue to go thru these blanket exceptions from the Easylist... Source: https://easylist.to/easylist/easylist.txt
|
@lukemulks for the websockets issue please post a different issue for it. I think we should move to the extensions web request APIs to get it for free rather than the way electron has it. |
sounds good @bbondy will do. |
Investigate Easylist.to primary .Txt list. Some 3p networks showing up with exceptions in ABP on Chrome w/acceptable ads disabled. Need to check impact on Brave blocking.
More info to come, when I get in front of a keyboard.
The text was updated successfully, but these errors were encountered: