Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to uBO lists + brave-unbreak.txt #113

Closed
pes10k opened this issue Jul 10, 2020 · 4 comments
Closed

Switch to uBO lists + brave-unbreak.txt #113

pes10k opened this issue Jul 10, 2020 · 4 comments
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented Jul 10, 2020

Please also remove the no-longer-shipped lists from https://github.com/brave/brave-core/tree/master/components/third_party/adblock/lists once this change lands.

@ryanbr
Copy link
Collaborator

ryanbr commented Jul 12, 2020

A few options how we can implement this:

  1. We could removed any Easylist/Easyprivacy rules. Leaving only differences. https://secure.fanboy.co.nz/disconnect.lists.txt
  2. Remove all Disconnect filters, except Social (facebook/twitter/linkedin) and select domains. https://secure.fanboy.co.nz/disconnect-mod.lists.txt (first attempt)

We can re-use the exisiting filename https://github.com/brave/adblock-lists/blob/master/brave-disconnect.txt to make the transition easier.

My preference would be just a clean slate (2.) with select filters.

@antonok-edm
Copy link
Collaborator

These two lists required support for hosts format lists, which was just released in v0.3.0. However, uBO was recently updated to use https://gitlab.com/curben/urlhaus-filter instead - an official version of this list is provided in the standard format.

@antonok-edm
Copy link
Collaborator

Closing, as of #120 this is handled in https://github.com/brave/adblock-resources rather than here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants