Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] SR image is not loaded on active tab when component is downloaded #10398

Open
srirambv opened this issue Jun 22, 2020 · 0 comments
Open
Assignees
Labels
ARM Android ARM related issues bug feature/new-tab OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

SR image is not loaded on active tab when component is downloaded

Steps to reproduce

Scenario1 : (Regression/Intermittent)

  1. Install SR build
  2. Keep first NTP open, no tiles
  3. Open a second new tab, tiles load and normal background image load
  4. Once SR component is downloaded reload first NTP no change only loads the custom tiles

Scenario 2:

  1. Install SR build
  2. Keep first NTP open, no tiles
  3. Open a second new tab, tiles load and normal background image load
  4. Wait for the component to download, first NTP loads custom assets
  5. Second tab which is active retains stock tiles and adds custom tiles, reload fixes it

Actual result

Scenario 1: https://bravesoftware.slack.com/archives/C0816QH3R/p1592820880353400
Scenario 2: https://bravesoftware.slack.com/archives/C0816QH3R/p1592822898353700

Expected result

SR images and tiles should be loaded on all tabs without causing any regressions

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? No
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Tablet Samsung Tab A
  • Android version: 9

Brave version

1.10.95

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Regression of #10033

@srirambv srirambv added bug feature/new-tab QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jun 22, 2020
@srirambv srirambv removed this from the Android 1.10.x Hotfix 1 Release milestone Jun 22, 2020
@srirambv srirambv added the ARM Android ARM related issues label Jun 22, 2020
@bsclifton bsclifton added this to Backlog in Android General Jan 13, 2021
@bsclifton bsclifton added the priority/P4 Planned work. We expect to get to it "soon". label Jan 13, 2021
@bsclifton bsclifton moved this from Backlog to P3 in Android General Jan 13, 2021
@bsclifton bsclifton moved this from P3 to P4/P5 in Android General Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Android ARM related issues bug feature/new-tab OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Development

No branches or pull requests

3 participants