Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Consider use Chromium java methods for sync v2 instead of native calls at brave_sync_worker.cc #10454

Open
AlexeyBarabash opened this issue Jun 24, 2020 · 1 comment
Open

[Android] Consider use Chromium java methods for sync v2 instead of native calls at brave_sync_worker.cc #10454

AlexeyBarabash opened this issue Jun 24, 2020 · 1 comment
Assignees
@AlexeyBarabash
Labels
feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Sync - All platforms

Comments

@AlexeyBarabash
Copy link
Contributor

From discussion with @darkdh

Lots of codes in this file seems like copy from PeopleHandler, and we can definitely leverage some methods like handling encryption, engine start/stop... in SyncAndServicesSettings.java and ProfileSyncService.java

brave/brave-core#5361 (comment)
@AlexeyBarabash AlexeyBarabash added feature/sync OS/Android Fixes related to Android browser functionality labels Jun 24, 2020
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 24, 2020
@AlexeyBarabash AlexeyBarabash mentioned this issue Jun 24, 2020
Merged
32 tasks
@jsecretan jsecretan added this to Untriaged backlog in Sync - All platforms Aug 25, 2020
@jsecretan jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Aug 25, 2020
@jsecretan jsecretan moved this from Untriaged backlog to P3, P4, & P5 backlog in Sync - All platforms Aug 25, 2020
@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 26, 2021
Merged
23 tasks
@AlexeyBarabash
Copy link
Contributor Author

+1 from discussion with @bridiver

speaking of android, why don't we use `SyncServiceAndroidBridge`?
seems we're duplicating a lot of that functionality
probably `BraveSyncWorker` still needs to exist, but a trimmed down version which only the differences
also we should probably rename to `BraveSyncServiceAndroidBridge`
...
but it definitely makes things more fragile across chromium updates
so shouldn't be too low priority
I always worry about duplicated code that needs to be kept in sync with upstream changes
I suppose we (hopefully) have tests that would catch it

cc @jsecretan

@AlexeyBarabash AlexeyBarabash added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Sync - All platforms
  
P3, P4, & P5 backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsecretan @AlexeyBarabash