Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Some asset icons not present for Binance widget #10733

Open
bbondy opened this issue Jul 14, 2020 · 0 comments
Open

[Desktop] Some asset icons not present for Binance widget #10733

bbondy opened this issue Jul 14, 2020 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jul 14, 2020

Description

Depending on the region, some asset icons are not available.

We should be getting the icons when the user has manually connected from this endpoint:
https://www.binance.com/exchange-api/v1/public/asset/asset/get-all-asset

Note: When this is implemented we should do a privacy review, I believe the assets will be served from cache after the first access. but a privacy review should be done.

For the disconnected view, we should only consider asset icons we have on hand so that no network calls are made by default.

Steps to Reproduce

I'm not sure how to reproduce, but I assume if you setup your account to with a different country you can see some assets without an icon

Reproduces how often:

Always or never, depending on the user.

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? n/a
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jul 14, 2020
@bbondy bbondy added this to Untriaged in Wallet via automation Jul 14, 2020
@ryanml ryanml added feature/widgets and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Jul 17, 2020
@bbondy bbondy added this to Untriaged in Widgets via automation Sep 8, 2020
@bbondy bbondy removed this from Untriaged in Wallet Sep 8, 2020
@srirambv srirambv changed the title Some asset icons not present for Binance widget [Desktop] Some asset icons not present for Binance widget Sep 9, 2020
@rebron rebron moved this from Untriaged to Backlog in Widgets Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Widgets
  
Backlog
Development

No branches or pull requests

3 participants