Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Shields dark theme not visible on dark pages #10831

Open
srirambv opened this issue Jul 21, 2020 · 2 comments
Open

[Android] Shields dark theme not visible on dark pages #10831

srirambv opened this issue Jul 21, 2020 · 2 comments
Assignees
@karenkliu
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Shields Android General

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 21, 2020 •
edited by karenkliu

Description

Shields dark theme not visible on dark pages

Steps to reproduce

  1. Visit https://jsfiddle.net/extra
  2. Open shields
  3. Shields is camouflaged on the page

Actual result

Expected result

Shields should have thin outline around edges:

image

Figma: https://www.figma.com/file/c5Sq98FXH6oz1z3FL8K3eN/?node-id=0%3A1

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NA
  • Beta build? Yes

Device details

  • Install type (ARM, x86):All
  • Device (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.11.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

This is a design bug
@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality labels Jul 21, 2020
@srirambv srirambv added this to Backlog in Android General via automation Jul 21, 2020
@srirambv srirambv added this to Untriaged / Incoming in Shields via automation Jul 21, 2020
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 2, 2020
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General Dec 2, 2020
@anthonypkeane
Copy link

@karenkliu what should we do in this case?

@karenkliu
Copy link

@anthonypkeane this was a bug - during QA i overlooked that the Shields in dark theme was missing a thin grey outline around the edges.

I added what it should look like to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Android General
  
P3
Shields
  
Untriaged / Incoming
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karenkliu @anthonypkeane @srirambv