Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Show warning when user tries to close code words modal #10859

Open
btlechowski opened this issue Jul 22, 2020 · 2 comments
Open

[Desktop] Show warning when user tries to close code words modal #10859

btlechowski opened this issue Jul 22, 2020 · 2 comments
Assignees
Labels
bug feature/sync OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

btlechowski commented Jul 22, 2020

In sync 1 closing code words modal during creation process did not matter because the sync chain was created anyway.

This is changed in sync 2 where closing the code words modal will cancel the creation process and therefor create new code words. User may not expect that new code words will be generated.

We show warning when user tries to reload the sync page when code words modal is shown. We should do the same when user cancels the process by pressing Escape or clicking x on code words modal

Steps to Reproduce

  1. Clean install
  2. Open brave://settings/braveSync/setup
  3. Click Start a new sync chain
  4. Click Computer
  5. Copy code words
  6. Click x located in the top right corner OR press Escape

Actual result:

Sync chain creation process is canceled without warning

Expected result:

Warning is shown

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
Brave 1.13.36 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @jsecretan @rebron @darkdh @AlexeyBarabash @yrliou @petemill

@btlechowski btlechowski added this to Untriaged backlog in Sync via automation Jul 22, 2020
@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 22, 2020
@darkdh darkdh moved this from Untriaged backlog to In progress in Sync Jul 29, 2020
@darkdh darkdh moved this from In progress to Untriaged backlog in Sync Jul 29, 2020
@GeetaSarvadnya
Copy link

Reproduced on Windows 10 x64 - 1.12.108

@jsecretan jsecretan added this to Untriaged backlog in Sync - All platforms Aug 25, 2020
@jsecretan jsecretan moved this from Untriaged backlog to P3, P4, & P5 backlog in Sync - All platforms Aug 25, 2020
@AlexeyBarabash
Copy link
Contributor

I can reproduce this .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/sync OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Sync - All platforms
  
P3, P4, & P5 backlog
Sync
  
Untriaged backlog
Development

No branches or pull requests

5 participants