Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] label changes for Google Safe Browsing made with #8002 need to be applied to translations #10887

Open
LaurenWags opened this issue Jul 23, 2020 · 3 comments
Assignees
Labels
bug feature/safebrowsing google l10n needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes
Projects

Comments

@LaurenWags
Copy link
Member

Description

Issue #8002 changed the label and text of "Safe Browsing" setting in brave://settings/privacy to include Google. This works in English but translated versions (ex. French, Japanese, probably others) do not mention Google.

Steps to Reproduce

  1. Using a language other than English, launch 1.11.99
  2. Open brave://settings/privacy
  3. Locate Safe Browsing setting

Actual result:

setting label and explanatory text does not mention Google
French:
French - Safe Browsing

Japanese:
Japanese - Safe Browsing

Expected result:

setting label and explanatory text should mention Google (not Brave) as it does for English (US)
English - Google Safe Browsing

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.99 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, translations are missing from 1.11.97
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron added this to Untriaged Backlog in General Jul 28, 2020
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. l10n labels Jul 28, 2020
@rebron rebron moved this from Untriaged Backlog to P1 & P2 Backlog in General Jul 28, 2020
@rebron rebron self-assigned this Sep 8, 2020
@LaurenWags
Copy link
Member Author

@rebron since this section in settings is changed with chromium 86, do we still need this issue?

@rebron
Copy link
Collaborator

rebron commented Mar 2, 2021

Issue is stale. As you mentioned settings changed in cr 86.

Screen Shot 2021-03-02 at 1 19 29 PM

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Mar 2, 2021
@fmarier
Copy link
Member

fmarier commented Mar 2, 2021

It's also an issue in brave://settings/privacy:
Screenshot from 2021-03-02 13-45-56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/safebrowsing google l10n needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes
Projects
Status: P1 & P2 Backlog
General
  
P1 & P2 Backlog
Development

No branches or pull requests

3 participants