Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fix chrome/browser circular deps in //brave/browser #10889

Open
1 task
Gyuyoung opened this issue Jul 24, 2020 · 0 comments
Open
1 task

[Desktop] Fix chrome/browser circular deps in //brave/browser #10889

Gyuyoung opened this issue Jul 24, 2020 · 0 comments

Comments

@Gyuyoung
Copy link

Gyuyoung commented Jul 24, 2020

The issue is filed for the circular dependency issue and it will be fixed later again.
There are still chrome/browser circular dependency issues in below targets.

  • //brave/browser/infobars
$gn check . //brave/browser/infobars/*

ERROR at //brave/browser/infobars/crypto_wallets_infobar_delegate.cc:19:11: Include not allowed.
#include "chrome/browser/infobars/infobar_service.h"
          ^----------------------------------------
It is not in any dependency of
  //brave/browser/infobars:infobars
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/infobars/crypto_wallets_infobar_delegate.cc:22:11: Include not allowed.
#include "chrome/browser/profiles/profile.h"
          ^--------------------------------
It is not in any dependency of
  //brave/browser/infobars:infobars
The include file is in the target(s):
  //chrome/browser:browser

@simonhong simonhong changed the title [Desktop] Fix chrome/browser deps in //brave/browser/infobars/* [Desktop] Fix chrome/browser circular deps in //brave/browser Jul 24, 2020
@jumde jumde added the gn_check label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants