Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release build shows update brave icon on app menu #1098

Closed
srirambv opened this issue Sep 12, 2018 · 1 comment
Closed

Release build shows update brave icon on app menu #1098

srirambv opened this issue Sep 12, 2018 · 1 comment
Assignees
@simonhong
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/updater needs-investigation A bug not 100% confirmed/fixed source-master

Comments

@srirambv
Copy link
Contributor

Description

Release build shows update brave icon on app menu

Steps to Reproduce

  1. Build from source
  2. Launch brave with npm run start -- Release
  3. App menu shows update brave, restart does nothing

Actual result:

image

Expected result:

Should not show any update notification on release/debug build from source

Reproduces how often:

No idea just saw it once now

Brave version (chrome://version info)

Brave 0.55.2 Chromium: 70.0.3538.12 (Official Build) (64-bit)
Revision ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added this to the 1.0 milestone Sep 12, 2018
@srirambv
Copy link
Contributor Author

Icon invisible on dark theme
image

@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/updater needs-investigation A bug not 100% confirmed/fixed source-master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bbondy @bsclifton @rebron @simonhong @srirambv