Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Search updates #11089

Closed
srirambv opened this issue Aug 5, 2020 · 2 comments
Closed

[Android] Search updates #11089

srirambv opened this issue Aug 5, 2020 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2020

Description (Issue carried over from #10890)

Small update to the engines we show by default

  • Add Yahoo as an option
  • Remove DDG Lite on Android
  • Add ability to localize engine based on country code

Related: https://github.com/brave/internal/issues/701, https://github.com/brave/internal/issues/700

Test plan (Android)

Verify Yahoo shows as an option in onboarding

  1. Fresh install
  2. Launch Brave and tap on search bar. it should open the onboarding
  3. Confirm Yahoo shows in list as first item on search engine onboarding

Verify Yahoo shows in settings

  1. Fresh install or update
  2. Launch Brave and go to settings
  3. Confirm Yahoo shows as the first item under Standard Tab and Private Tab

Verify DuckDuckGo Lite is removed

  1. Fresh install
  2. Launch Brave and tap on search bar. it should open the onboarding
  3. Confirm DuckDuckGo Lite is NOT in search engine onboarding
  4. Go to settings
  5. Confirm DuckDuckGo Lite is NOT shown as an option
@srirambv srirambv added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Aug 5, 2020
@srirambv srirambv added this to the Android 1.12.x - Beta milestone Aug 5, 2020
@srirambv
Copy link
Contributor Author

srirambv commented Aug 5, 2020

Fixed with brave/brave-core#6201

@srirambv srirambv closed this as completed Aug 5, 2020
@srirambv srirambv added this to Closed in Android Core 1.12 Aug 5, 2020
@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.12.109

Clean Install

Verified DDG Lite is removed from the onboarding
Verified DDG is removed from search settings as well
Normal search settings Private search settings
image image
Verified Yahoo is shown as an option in onboarding

Upgrade Install

Verified if DDG Lite is set as default in previous version it is retained during upgrade
Normal tab search setting Private tab search setting
image image

Other tests

  • Verified regional search uses localized version of Yahoo search as per spec

  • Follow up issues

  • Logged [Android] Yahoo is not listed for non-supported region #11080 for Yahoo not being shown in onboarding or under search settings for unsupported regions
  • Logged [Android] Yahoo isn't the first SE on the list post upgrade #11082 for Yahoo not being the first SE on upgrade

  • Logged #11145 for Tablet. Need to reverify issue once its fixed for tablet

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
    Projects
    No open projects
    Development

    No branches or pull requests

    2 participants