Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] add Greaselion configuration flag for incognito mode #11409

Closed
diracdeltas opened this issue Aug 24, 2020 · 5 comments
Closed

[Desktop] add Greaselion configuration flag for incognito mode #11409

diracdeltas opened this issue Aug 24, 2020 · 5 comments
Assignees
@emerick @pilgrim-brave
Labels
closed/no-milestone greaselion OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. security

Comments

@diracdeltas
Copy link
Member

as discussed in https://github.com/brave/security/issues/215#issuecomment-679349124, greaselion scripts run in incognito mode by default. we should add a configuration option in https://github.com/brave/brave-site-specific-scripts#configuration-file-format that indicates if the script should run in incognito contexts, since generally scripts that are related to rewards/ads should not.
@diracdeltas
Copy link
Member Author

i would prefer this default to not allowed in incognito mode.

@emerick
Copy link
Contributor

emerick commented Aug 24, 2020

cc: @pilgrim-brave

@rebron rebron added this to New Issues in Rewards via automation Sep 25, 2020
@bsclifton bsclifton changed the title [Desktop] add greaselion configuration flag for incognito mode [Desktop] add Greaselion configuration flag for incognito mode Oct 26, 2020
@NejcZdovc NejcZdovc removed this from New Issues in Rewards Oct 28, 2020
@diracdeltas diracdeltas mentioned this issue Feb 21, 2021
Open
@Miyayes Miyayes added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Feb 21, 2021
@emerick emerick mentioned this issue Mar 22, 2021
Closed
@emerick
Copy link
Contributor

emerick commented Mar 22, 2021 •
edited

Is this issue still relevant in light of this recent commit: brave/brave-core@6bbdfb1?

cc: @darkdh

@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 22, 2021 •
edited

@darkdh does this mean there's no way for greaselion scripts to run in incognito windows? (if so this issue can be closed)

@bsclifton
Copy link
Member

Sorry for digging up an old issue! But it does look like that's correct- Greaselion shouldn't be running in Incognito (private) windows.
https://github.com/brave/brave-core/blob/679a703ce6c2149199f208e72bc5eb3fdbe1e367/components/greaselion/browser/greaselion_service_impl.cc#L117-L118

Confirmed by opening a private window and then opening Twitter and not seeing tips button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@pilgrim-brave pilgrim-brave

Labels
closed/no-milestone greaselion OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@diracdeltas @bsclifton @emerick @Miyayes @pilgrim-brave