Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Web Extension Inconsistency. Simple / Mystery #11593

Open
ImprovedTube opened this issue Sep 4, 2020 · 3 comments
Open

[Desktop] Web Extension Inconsistency. Simple / Mystery #11593

ImprovedTube opened this issue Sep 4, 2020 · 3 comments
Labels
needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects

Comments

@ImprovedTube
Copy link

ImprovedTube commented Sep 4, 2020

Description

A simple Extension feature wont work consistently for no apparent reason, as it works in Google Chrome in every OS
Our themes working in Brave are same to those that dont work. code-charity/youtube#521

Steps to Reproduce

Enable Improvedtube Youtube Themes:
https://chrome.google.com/webstore/detail/improve-youtube-open-sour/bnomihfieiccainjcjblhegjgglakjdd
Edit: Only Desert & Plain don't work. Thats the Mystery

Actual result: -

Expected result:

Themes all working in exactly the same way.
(Night, Dawn, Sunset, Desert, Plain, Black.
(Except 'Dark', which refers to Youtube's night mode )

Reproduces how often:

always

Brave version (brave://version info)

84.0.4147.89 - 84.0.4147.135

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES instantly reproduced. Takes you few clicks
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NO
  • Does the issue resolve itself when disabling Brave Rewards? NO
  • Is the issue reproducible on the latest version of Chrome? Chromium? (Google Chrome: NO)

Miscellaneous Information:

@ImprovedTube ImprovedTube changed the title [Desktop] Web Extension Inconsistency. Simple / Mystery [Desktop?] Web Extension Inconsistency. Simple / Mystery Sep 4, 2020
@ImprovedTube ImprovedTube changed the title [Desktop?] Web Extension Inconsistency. Simple / Mystery Web Extension Inconsistency. Simple / Mystery [Desktop?] Sep 4, 2020
@srirambv srirambv changed the title Web Extension Inconsistency. Simple / Mystery [Desktop?] [Desktop] Web Extension Inconsistency. Simple / Mystery Sep 4, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 16, 2020

@ImprovedTube Are you still seeing this issue with 1.15.75 Chromium 86?

@rebron rebron added needs-more-info The report requires more detail before we can decide what to do with this issue. webcompat/not-shields-related Sites are breaking because of something other than Shields. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 16, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 16, 2020

@ImprovedTube Looks like this is working except for maybe two of the styles? Please add some information on expected outcome, if you'd like us to take a look.

Screen Shot 2020-10-16 at 9 35 06 AM

@rebron rebron added this to P5 Backlog in General Oct 16, 2020
@ImprovedTube
Copy link
Author

thank you @rebron !
did you click all themes, desert, plain?
happens in Opera too according to our user. "it doesn't seem to be fixed on my end" https://i.vgy.me/Iw9Jms.webm
"Tested on the latest versions of Opera GX and Brave, on Windows 10 Home. Also tested on Ubuntu 20.04 with Brave."
( code-charity/youtube#521 (comment) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Status: P5 Backlog / waiting upstream
General
  
P5 Backlog / waiting upstream
Development

No branches or pull requests

2 participants