Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting to disable Brave Rewards Notifications #1163

Closed
LaurenWags opened this issue Sep 17, 2018 · 4 comments
Closed

setting to disable Brave Rewards Notifications #1163

LaurenWags opened this issue Sep 17, 2018 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Brave Payments has a setting to disable notifications entirely, Brave Rewards should have this as well.

Steps to Reproduce

  1. With Brave Rewards enabled, navigate to chrome://rewards.
  2. Look for a way to disable Brave Rewards Notifications.

Actual result:

No way to disable Brave Rewards Notifications.

Expected result:

Should be a way to disable Brave Rewards Notifications.

Reproduces how often:

easily

Brave version (chrome://version info)

all

Reproducible on current release:

yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

On browser-laptop (muon) this is located on the Payments page (about:preferences#payments) when you click on the gear icon.

@bsclifton bsclifton added the feature/global-settings Settings at browser level independent of shields settings label Sep 17, 2018
@bsclifton bsclifton added this to the 1.0 milestone Sep 17, 2018
@rebron rebron added the design A design change, especially one which needs input from the design team label Sep 17, 2018
@NejcZdovc
Copy link
Contributor

@davidtemkin
Copy link

The notification system for Brave Rewards is different (and has yet to be implemented).

Not sure we want to do this.

  1. UX is different -- red dot on BR icon vs. browser notification
  2. No notifications are generated until the user opts in to BR (except for the initial "1" to get the user to open the panel)
  3. Once a user has opted in, we need a way of notifying them, period.

Suggest we close this

@LaurenWags
Copy link
Member Author

Per discussion in today's b-c triage meeting with @davidtemkin and @kjozwiak - going to close this one out.

@LaurenWags LaurenWags removed this from the 1.0 milestone Sep 18, 2018
@bbondy bbondy added this to the Dupe / Invalid / Not actionable milestone Sep 22, 2018
@bbondy
Copy link
Member

bbondy commented Sep 22, 2018

Added to dupe / invalid / not actionable milestone.
We want everything part of some milestone for triage reasons.

@kjozwiak kjozwiak removed browser-laptop-parity design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/rewards labels Oct 22, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants