Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Ads in Video Grid #11955

Closed
jonathansampson opened this issue Oct 1, 2020 · 5 comments · Fixed by brave/adblock-lists#1073
Closed

YouTube Ads in Video Grid #11955

jonathansampson opened this issue Oct 1, 2020 · 5 comments · Fixed by brave/adblock-lists#1073
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@jonathansampson
Copy link
Contributor

Description

Ads are often displayed in the first video slot on the Home page of youtube.com.

image

While Brave's aggressive mode is able to hide these, it leaves an empty container where the video element would have existed.

image

Steps to Reproduce

  1. Go to youtube.com (logged-in)
    2 Select Home from the left

Actual result:

User is often shown ad ad-result in the first video slot.

Expected result:

User should be able to block these elements, without leaving an empty region on the page.

Reproduces how often:

Not always, but often.

Desktop Brave version:

Testing in 1.14.84

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? TBD
  • Can you reproduce this issue with the nightly channel? TBD
@jonathansampson jonathansampson added feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality features/shields/cosmetic-filtering OS/Desktop labels Oct 1, 2020
@ryanbr
Copy link

ryanbr commented Oct 6, 2020

I mostly fixed this in easylist/easylist@7e39a57 which removed the advert people were complaining about, but didn't collapse the advert.

uBO callapses this element with youtube.com##ytd-display-ad-renderer:upward(2) in https://github.com/uBlockOrigin/uAssets/blob/master/filters/filters.txt @antonok-edm

@antonok-edm
Copy link
Collaborator

Will need support for procedural cosmetic filter implementations in both brave-core and adblock-rust.

@jcosentino
Copy link

I wanted to report that I am also experiencing this:
youtube brave unhidden element

I tried adding this filter:
youtube.com##ytd-display-ad-renderer:upward(2)

But this was to no avail.

@nithinkodadhavadee
Copy link

I know you guys are still working on this, but just another update. I got this too, I didn't have this until now but I can see ads everywhere. Video ads, banners, everywhere on youtube.

image

image

even in google search
image

@0x802
Copy link

0x802 commented Nov 7, 2022

Please remove this ad !!

image


The xpath for the ad is :

/html/body/ytd-app/div[1]/ytd-page-manager/ytd-browse/ytd-two-column-browse-results-renderer/div[1]/ytd-rich-grid-renderer/div[3]/ytd-ad-slot-renderer/div/ytd-page-top-ad-layout-renderer/div/ytd-video-masthead-ad-v3-renderer/div/div[2]/ytd-video-masthead-ad-primary-video-renderer/div[2]/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants