Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puzzle icon for autoplay to an autoplay specific icon #1203

Closed
rebron opened this issue Sep 20, 2018 · 9 comments
Closed

Update puzzle icon for autoplay to an autoplay specific icon #1203

rebron opened this issue Sep 20, 2018 · 9 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 20, 2018

Description

Currently using puzzle icon with red x mark. Need an autoplay specific icon.

screen shot 2018-09-19 at 11 26 15 pm

Related

#699

Test plan

Visit https://tesla.com/model3
Autoplay blocked icon should look like:
image

@rebron rebron added this to the 1.0 milestone Sep 20, 2018
@rebron rebron changed the title create autoplay icon replace autoplay icon Sep 21, 2018
@rossmoody
Copy link
Contributor

How do we feel about adjusting the scope of this to updating permissions icons for default and blocked states?
image

I think these icons also live in site settings page though i'm unsure if they are all pulling from the same place.

@bbondy bbondy added this to Branding in 1.0 Tasks by Category Sep 29, 2018
@rebron rebron changed the title replace autoplay icon update permission icons for default and blocked states Oct 2, 2018
@rebron
Copy link
Collaborator Author

rebron commented Oct 3, 2018

looks like different icons on chrome://settings/content

@rossmoody
Copy link
Contributor

yeah, i think those are generated by iron icons which pulls from a different place than the omnibox, so we should prob break those changes out into another issue, some of them might get or be partially resolved with clifton's settings updates

@petemill
Copy link
Member

petemill commented Oct 4, 2018

This issue seems to now have a broad scope for all ombnibox permission icons, but brave/brave-core#548 is only addressing autoplay and the generic extension icon, right @rossmoody ?

@rossmoody rossmoody changed the title update permission icons for default and blocked states Update puzzle icon for autoplay to an autoplay specific icon Oct 4, 2018
@rossmoody
Copy link
Contributor

@rebron @petemill yeah that was an ill conceived suggestion. I do think replacing that lineup is important but there is additional consideration, sizes, and places that a change like that needs to take into account. should open up a separate issue, i adjusted the scope of this back to the original

@srirambv
Copy link
Contributor

srirambv commented Oct 10, 2018

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows

@kjozwiak
Copy link
Member

kjozwiak commented Oct 11, 2018

@rossmoody quick question regarding our current icon set while using the dark theme. Is there plans to incorporate a white set of icons for the dark theme? They're pretty hard to see with the current set when using the dark theme.. Example:

screen shot 2018-10-11 at 12 49 35 am

@rossmoody
Copy link
Contributor

I agree, Bookmark icons as well. Would like to switch the shield alert circle to purple in dark theme instances as well. There is a huge list of UI adjustments on the docket but shields/rewards are consuming all atm.

@kjozwiak
Copy link
Member

@rossmoody sounds good! Appreciate the update. Guessing there's no need to create issues. Sounds like it's on the list of things to do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment