Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code for iOS Rewards users transferring BAT is not translated in brave://rewards #12282

Closed
btlechowski opened this issue Oct 22, 2020 · 4 comments

Comments

@btlechowski
Copy link

Follow up to #12176. The new strings are not translated

Steps to Reproduce

  1. Enable Rewards
  2. Open brave://rewards

Actual result:

QR Code for iOS Rewards users transferring BAT is not translated
QR Code is not translated
image
image

Expected result:

QR Code for iOS Rewards users transferring BAT is translated
QR Code is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @mkarolin

@BAT-HMA

This comment has been minimized.

@LaurenWags
Copy link
Member

@BAT-HMA QR code to be implemented with #13159. You'll want to follow that issue for the most current updates and target release.

@brave brave deleted a comment from mukarimin Dec 27, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 12, 2021

@btlechowski Is this still an issue?

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 12, 2021
@btlechowski
Copy link
Author

btlechowski commented Feb 12, 2021

It is fixed

Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image


Verified passed with

Brave | 1.21.54 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | macOS Version 10.15.7 (Build 19H512)

Verified STR from description for below languages.

French German
French German

Verification passed on


Brave | 1.21.56 Chromium: 88.0.4324.152 (Officiële build) dev (64-bits)
-- | --
Revisie | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
Besturingssysteem | Windows 10 OS Version 2004 (Build 19041.804)


Verified STR from description for below languages.
Dutch (Netherland)
image

Kannada (India)
image

@btlechowski btlechowski added this to the 1.21.x - Beta milestone Feb 12, 2021
@rebron rebron added this to Completed in General Feb 16, 2021
@rebron rebron removed this from Completed in General Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants