Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave News / NTP responsiveness #12700

Open
karenkliu opened this issue Nov 13, 2020 · 3 comments
Open

Fix Brave News / NTP responsiveness #12700

karenkliu opened this issue Nov 13, 2020 · 3 comments
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@karenkliu
Copy link

karenkliu commented Nov 13, 2020

Description

The NTP layout has remained the same while more elements have been added, causing some responsive issues over time. NTP content at the bottom of the screen is overlapping with each other and interfering with the visibility of the Brave News scroll hint.

Steps to Reproduce

  1. Open a new tab page
  2. Make the window more narrow
  3. See bottom NTP content start to overlap

Actual result:

Screen Shot 2020-11-13 at 2 55 07 PM

Screen Shot 2020-11-13 at 2 55 13 PM

Screen Shot 2020-11-13 at 2 55 20 PM

Expected result:

NTP content at the bottom does not overlap in a way that interferes with visibility of each item with these updates:

  • Remove Bookmarks, Settings, and History icon (will be moved to the sidebar soon)
  • Use the same "Customize" button style as currently implemented when scrolling Brave Today. It sits on top of all NTP content
  • Hide widget stack and clock at breakpoints =<730
  • Photo attribution and sponsored image logo should stack on top of the Brave Today scroll hint at breakpoints =<730
  • NTP Stats vertically centered at breakpoints <=730

Breakpoints => 1000
image
image

When scaling vertically, the bottom NTP furniture stays sticky and visible at the bottom of the screen. The "Customize" button always stays on top of other NTP furniture.

1000+ vertical

The widget stack will be the first to overflow. Enable the user to scroll to the bottom of the NTP content before beginning the blurred background scroll effect for Brave Today.

1000+ vertical scrolling

Breakpoints 731-999

Group 129

The photo attribution and sponsored image logo stays sticky on the bottom until it hits NTP furniture above it. At that point, it becomes part of the scrollable content. NTP furniture is scrollable when viewport height is less than the total height of the widgets. The user must scroll so the bottom of NTP furniture before starting the Brave Today blurred background effect.

medium.screen.mp4

Breakpoints <=730

image

small.screen.mp4

Reproduces how often:

Easily

Brave version (brave://version info)

All versions

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Figma: https://www.figma.com/file/FMuS3IZbzqzQTyRHz42Oix/?node-id=57%3A12408

@rebron
Copy link
Collaborator

rebron commented Nov 16, 2020

cc: @petemill can you help with prioritization on this one?

@rebron rebron removed their assignment Nov 16, 2020
@rebron rebron changed the title [Desktop] Fix Brave Today / NTP responsiveness Fix Brave Today / NTP responsiveness Nov 16, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 16, 2020
@rebron rebron added this to P3 backlog in New Tab page Nov 16, 2020
@rebron rebron moved this from P3 backlog to In progress in New Tab page Jan 20, 2021
@karenkliu
Copy link
Author

@petemill @ryanml I added details for vertical scaling as well.

@rebron rebron added this to Backlog in Brave News Jan 25, 2021
@rebron rebron moved this from Backlog to P2/P3/P4 in Brave News Jan 25, 2021
@rebron rebron moved this from In progress to P3 backlog in New Tab page Jan 26, 2021
@bsclifton bsclifton changed the title Fix Brave Today / NTP responsiveness Fix Brave News / NTP responsiveness Jun 14, 2021
@rebron rebron moved this from P3 backlog to On Deck in New Tab page Aug 9, 2021
@mattmcalister mattmcalister moved this from P2/P3/P4 to Backlog - Desktop in Brave News Mar 8, 2022
@mattmcalister mattmcalister added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 8, 2022
@mattmcalister mattmcalister removed this from Desktop in Brave News Mar 9, 2022
@lazymonkey2
Copy link

scrolling is still too slow on brave news.
any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
No open projects
Development

No branches or pull requests

4 participants