Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's make Greaselion more informative for debugging! #12796

Open
mrose17 opened this issue Nov 19, 2020 · 0 comments
Open

Let's make Greaselion more informative for debugging! #12796

mrose17 opened this issue Nov 19, 2020 · 0 comments
Assignees

Comments

@mrose17
Copy link
Member

mrose17 commented Nov 19, 2020

Description

At present, the only diagnostic logging occurs when there's an error in Greaselion.json

...:ERROR:greaselion_download_service.cc(234)] Failed to parse Greaselion configuration

Otherwise, everything is silent. It would make debugging Greaselion issues a lot easier if these additions were made when running with --enable-logging --v=1:

  1. when there is a match against an element in the urls array for a rule, there is a log entry
  2. if one of entries in the preconditions array fails, there is a log entry indicating the offset of the array failed
  3. otherwise, for each entry in the scripts array, there is a log entry indicating that the script was loaded and whether there were any errors (or not).

Steps to Reproduce

Go to a URL that invokes Greaselion. There is no diagnostic logging.

Actual result:

Go to a URL that invokes Greaselion. There is no diagnostic logging.

Expected result:

Go to a URL that invokes Greaselion. Get some diagnostic logging.

Reproduces how often:

100%

Brave version (brave://version info)

1.19.21

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? yes

Miscellaneous Information:

N/A

@marshall marshall added this to Backlog in Brave Rewards via automation Nov 19, 2020
@emerick emerick self-assigned this Dec 3, 2020
@zenparsing zenparsing added greaselion priority/P4 Planned work. We expect to get to it "soon". labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Backlog
Development

No branches or pull requests

4 participants