Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicons are not visible prominently in Dark mode #12810

Open
GeetaSarvadnya opened this issue Nov 20, 2020 · 2 comments
Open

Favicons are not visible prominently in Dark mode #12810

GeetaSarvadnya opened this issue Nov 20, 2020 · 2 comments
Labels
Projects

Comments

@GeetaSarvadnya
Copy link

Description

favicons are not visible prominently in Dark mode

Steps to Reproduce

  1. Open Brave 1.18.x
  2. Change appearance settings to Dark mode
  3. Visit brave://settings/cookies
  4. Open a PT window and visit any site
  5. Come back to brave://settings/cookies again
  6. favicons are not visible prominently in Dark mode

Actual result:

favicons are not visible prominently in Dark mode
image

Expected result:

Favicons should be lighter color in dark theme

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.18.57 Chromium: 87.0.4280.66 (Official Build) beta (64-bit)
Revision fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS Windows 10 OS Version 2004 (Build 19041.572)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @karenkliu

@karenkliu
Copy link

Yeah just make it the same color as the globe icon to its left. Not sure the theme isn't picking it up.

@rebron rebron added this to Untriaged Backlog in General Nov 24, 2020
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Dec 1, 2020
@rebron rebron removed this from Untriaged Backlog in General Dec 1, 2020
@rebron rebron added this to P4 backlog in Front End Dec 8, 2020
@PandaSupremacy
Copy link

Make the colours of the favicons save as the ones in the settings so as they they stand out in the particular screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Front End
  
P4 backlog
Development

No branches or pull requests

4 participants