Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave raised an app notification during sleeping hours (ex: 4:45am) #13110

Open
jspraul opened this issue Dec 9, 2020 · 9 comments
Open

Brave raised an app notification during sleeping hours (ex: 4:45am) #13110

jspraul opened this issue Dec 9, 2020 · 9 comments
Assignees
Labels
feature/notifications OS/Android Fixes related to Android browser functionality

Comments

@jspraul
Copy link

jspraul commented Dec 9, 2020

I searched for 'notification -"manual test" sort:comments-desc' and didn't see anything related in the 3 issues not starting with 'Manual Test Run'.

Description

Brave initiated a notification on my phone this morning just to wake me up at 4:45am.

Steps to reproduce

  1. Skip the intro to the Brave Android app
  2. Go to sleep

Actual result

  1. Get woken up by a notification initiated by Brave at 4:45am

Expected result

  1. Stay asleep

Issue reproduces how often

Once so far, not 100% on the cause; guessing it was because I closed the intro that is displayed when loading Brave for the first time after it is installed on the device. I pretty much closed the notification immediately in groggy anger.

Version/Channel Information:

This was the Play Store version. Sorry, but I'm not interested in installing the other versions and attempting to reproduce the issue.

Device details

  • Install type ARM
  • Device type Phone
  • Android version 10

Brave version

Brave 1.17.75, Chromium 87.0.4280.88

Website problems only

N/A

Additional information

I have disabled all notifications for the Brave Android app.

@jspraul jspraul added the OS/Android Fixes related to Android browser functionality label Dec 9, 2020
@kenherbert
Copy link

It is not for an app to say what time a person should or should not receive a notification for something, because every person's lifestyle is different. A few years ago I would have been more than happy with a notification at 5am, but not one at midday, because I was working nights.

This is why phones have do not disturb settings so you can turn off all notifications within certain hours of your own choosing.

@jspraul
Copy link
Author

jspraul commented Dec 9, 2020

Thanks for sharing your opinion in response to mine my friend!

@bsclifton
Copy link
Member

Thanks for the assist there @thefallofbecause - DnD is what we would recommend too 😄 You should be able to change the per-app notifications also. Thanks! 😄👌

@jspraul
Copy link
Author

jspraul commented Dec 9, 2020

Ok.

FWIW, here is the list of Android apps apart from Brave that have woken me up with a marketing notification in the past several years:

@bsclifton
Copy link
Member

@jspraul this was a Brave ads notification? And not a regular application notification?

@tmancey are ads presented when the phone is locked?

@jspraul
Copy link
Author

jspraul commented Dec 10, 2020

No, sorry for the confusion. IIRC it was a notification to return to the introductory tutorial/intro pop-up screen... but as I mentioned I don't really remember much, sorry. I should not have said marketing since my interpretation is probably non-standard (something designed pull new users back into the app = marketing to me).

All I'm asking for is for some empathy towards those with family and friends who can't really afford to shut down notifications, and 'ain't got time for that' to setup everything properly for just their contacts, etc. or however it is technically correct to be done.

Keep up the good work!

@tmancey
Copy link
Contributor

tmancey commented Dec 10, 2020

@bsclifton Ads are only presented when the phone is awake. Thanks

@tmancey
Copy link
Contributor

tmancey commented Dec 10, 2020

For reference, if the phone is awake and brave is backgrounded on Android. Ads are not shown between 9pm and 6am. If the phone is awake and foregrounded ads can be shown.

@bsclifton
Copy link
Member

bsclifton commented Dec 10, 2020

Awesome! Thanks for confirming, @tmancey 😄 Seems it was the app (Brave proper, not ads) that was sending the notification (RE: finishing onboarding)

Should we consider a similar time restriction @anthonypkeane? I'll re-open ticket until we can answer that

@bsclifton bsclifton reopened this Dec 10, 2020
@bsclifton bsclifton changed the title Brave woke me up with a notification at 4:45am Brave raised an app notification during sleeping hours (ex: 4:45am) Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notifications OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

5 participants