Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow Progressive Web Apps (PWAs) to Open in Incognito Mode #13865

Open
redactedscribe opened this issue Jan 31, 2021 · 6 comments
Labels
feature/private-browsing features/apps OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@redactedscribe
Copy link

Description

Allow PWAs (Progressive Web Apps) to open in incognito mode.

Steps to Reproduce

After adding a shortcut to the desktop and making sure it opens in a window, editing the properties (via desktop) to include the --incognito option and launching the PWA seems to have no effect.

Expected result

This may not be a feature of Chrome, but I'd like to see it in Brave.

Brave version (brave://version info)

Brave		1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS		Windows 10 OS Version 2009 (Build 19042.746)
@pitsi
Copy link

pitsi commented Feb 1, 2021

Please allow me a question. Does the command for your pwa look similar to this?
brave-browser --app=https://web.skype.com --incognito

@redactedscribe
Copy link
Author

"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\chrome_proxy.exe" --profile-directory="Profile 2" --app-id=<string> --incognito

<string> is a random string of letters.

I created the PWA via Brave: Hamburger icon/More tools/Create shortcut...

In fact, I'm not sure if the PWA is in incognito mode or not as I do not know if the PWA UI would show an icon / purple UI color like normal Brave private windows do. Is there some way to confirm if the PWA is running in incognito mode?

@pitsi
Copy link

pitsi commented Feb 2, 2021

I just made one, for facebook! I am on linux, so the relevant line looks like so
brave-browser --profile-directory=Default --app-id=(string)

Adding --incognito seems to have no effect, because I can see the extra entries created in brave://history. And that is the same problem I have with my --app approach above, the --incognito part seems to be ignored.
I have tried it on a lot of chromium based browsers (chromium and chrome on windows and linux, brave and opera on linux only) and the result is always the same. As a workaround, I once used the guest profile like so
brave-browser --guest --app=https://www.example.com
It stores nothing on history, but because it the guest aka "very barebones" profile, it has no support for addons etc. And next time you launch the browser from its regular shortcut, you must select which profile to use :(

I also searched for ways to identify if the browser is running on incognito mode, but all I found on stack exchange does not work nowadays, probably because the engine can really hide it from the web pages.
I have seen scripts that say it is running on incognito mode while it is not and vice versa.

@pitsi
Copy link

pitsi commented Feb 2, 2021

Hmmm. How do I remove a pwa now? I noticed that every time I right click on a facebook related link, there is an extra entry saying "open link in facebook" and it just opens that link in brave's app mode (no address bar etc).
I deleted the shortcut from my desktop but the entry is still there.

@srirambv
Copy link
Contributor

srirambv commented Feb 2, 2021

How do I remove a pwa now?

Go to brave://apps and right click on the PWA you want to remove and select Remove from Brave. This should uninstall PWA's.

As for the original request I don't think its possible for PWA's to run in Incognito mode. PWA's "pretends" to be native apps so ideally works as an app rather than like a browser window where you get normal/private mode.

cc: @bsclifton

@pitsi
Copy link

pitsi commented Feb 2, 2021

Thank you for the clarification. Now that I know the reason it does not work, I will stop trying :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/private-browsing features/apps OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

4 participants