Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Public DNS over HTTP server" text in Settings select widget is cropped #14478

Closed
stephendonner opened this issue Mar 4, 2021 · 3 comments
Closed
Assignees
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@stephendonner
Copy link

Description

Public DNS over HTTP server text in Settings select widget is cropped

Steps to Reproduce

  1. go to brave://flags
  2. search for "unstoppable"
  3. choose "Enabled"
  4. restart Brave
  5. load brave.crypto, and click Proceed using Cloudflare server
  6. go to brave://settings and under Method to resolve unstoppable domains" choose "Public DNS over HTTPS server"
  7. click to dismiss the select widget, and notice the length/appearance of the text

Actual result:

Even with a full-width, 2880x1800 display, the preference text is cropped, and reads Public DNS over HTTPS serv

Screen Shot 2021-03-04 at 3 03 02 PM

Screen Shot 2021-03-04 at 3 25 44 PM

Expected result:

Text should either be cropped with an ellipsis "..." or some other shorter text/titletip.

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @karenkliu @yrliou

@stephendonner stephendonner added OS/Desktop feature/web3/unstoppable-domains Label for unstoppable domains feature labels Mar 4, 2021
@karenkliu karenkliu added this to To do - Buttons in Design System via automation Mar 8, 2021
@karenkliu karenkliu moved this from To do - Buttons to To do - Dropdown in Design System Mar 8, 2021
@karenkliu
Copy link

This needs to be swapped out with our standardized dropdown component.

@bbondy bbondy added this to Untriaged in Wallet via automation Mar 9, 2021
@bbondy bbondy moved this from Untriaged to Brave Wallet Backlog in Wallet Mar 12, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 12, 2021
@yrliou
Copy link
Member

yrliou commented Mar 25, 2021

I believe this is not an issue anymore after brave/brave-core#8317 is merged.
Closing here, please reopen if it is still reproducible. cc @stephendonner

@yrliou yrliou closed this as completed Mar 25, 2021
Wallet automation moved this from Brave Wallet Backlog to Done Mar 25, 2021
Design System automation moved this from To do - Dropdown to Done Mar 25, 2021
@yrliou yrliou added this to the Closed / Dupe / Invalid milestone Mar 25, 2021
@stephendonner
Copy link
Author

Verified; the string is now DNS over HTTPS so fits much better into the <select> widget, in English, with more room for l10n.

Brave 1.24.26 Chromium: 90.0.4430.30 (Official Build) nightly (x86_64)
Revision 5674335ff855e43f3bccf8cfc29a779bdf0d067f-refs/branch-heads/4430@{#532}
OS macOS Version 11.2.3 (Build 20D91)

Screen Shot 2021-03-25 at 4 02 09 PM

@bbondy bbondy moved this from Done to Shipped in Wallet Jul 21, 2021
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Wallet
Closed
Development

No branches or pull requests

4 participants