Changes made via Edit site for Frequently Visited site don't persist

[stephendonner]

Description

Changes made via Edit site for Frequently Visited site don't persist

Steps to Reproduce

1. new profile, generate browsing history
2. open a new-tab page
3. hover over a Frequently Visited site and choose Edit site
4. make a change to its Name (so it's visible)
5. click Save
6. notice the new-tab page's mode now changes to Favorites
7. hover over to the top-right of the last Favorite site - the region with the ellipses ... - and choose Show frequently visited
8. look at the Name of your edited site from step 4

Actual result:

In the above screencast, I changed it to Weather, and the name remains the same; no changes were applied.

Expected result:

If we expose an Edit feature it should let the user apply changes; so, to the Name and URL, here.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.23.25 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? no
• Can you reproduce this issue with the nightly channel? yes

[GeetaSarvadnya]

Reproduced the issue in Windows 10 x64 - 1.23.59

[rebron]

@karenkliu @simonhong This might be a wontfix and could be a UE quirk we need to live with. Editing the name of sites from Frequently Visited is meant to send you over to Top Sites mode and from there can make customizations as you wish.

We're not allowing you to actually edit or change anything when in Frequently Visited mode. It's a little confusing, but I'm not sure we address it.

[karenkliu]

I'm kind of confused about this issue; if this is a fresh browser profile with a list of frequently visited sites, editing a site will switch you over to Favorites mode - keeping the exact same set of sites you had in frequently visited mode. It would also include the edit you just made.

Per the spec:

Clicking “Show frequently visited” will restore the Top Sites widget back to its default setting of auto-populating with frequently visited sites. The 6 available tiles will start changing again based on frequently visited sites from that point forward.

If you had more than 6 in Favorites mode, I assume it would just show the first 6 if you switched back to Frequently Visited mode. Top sites should not be remembering previous sets of tiles in either Favorites or Frequently Visited mode. It only starts changing what's shown through auto-populating or manual input from whatever the current set of tiles were at the point the user switched modes.

[simonhong]

This is expected behavior. When user edit site from most visited tiles, edited site data is managed by favoriate list
and original data is still managed by most visited tiles. Both mode have separated tiles set after user starts editing.

[Brave-Matt]

Chiming in here -- whether or not this behavior is correct/expected, it is certainly confusing at minimum.
The site labels are not always great (image for example) and it makes sense that users would want to change/adjust them. Separate features or not, I would argue that:

• You should be able to edit the name/label of the Frequently visited sites at minimum. Again, the browser isn’t always great at picking appropriate names for the tiles
• If it just simply “can’t be done”, then the Edit option should be removed from the Frequently visited tiles entirely since you can’t do anything with it.

Plus even if you do try and edit it, it’s not reflected on the Freq. visited tile or on the favorites tile. It looks as though absolutely nothing happens.

[fallaciousreasoning]

The above pull request should partially fix the issue - changes you make will be persisted, but in Favorites mode rather than Frequently visited mode.