Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive icon to Brave Release/Beta/Nightly #14660

Open
rodrigoswz opened this issue Mar 12, 2021 · 0 comments
Open

Adaptive icon to Brave Release/Beta/Nightly #14660

rodrigoswz opened this issue Mar 12, 2021 · 0 comments
Labels
design A design change, especially one which needs input from the design team misc/icons OS/Android Fixes related to Android browser functionality

Comments

@rodrigoswz
Copy link

Description

Adaptive icons is a very old feature, introduced in Android 8.0 but unfortunately it does not yet exist in Brave.

An adaptive icon allows the icon format to match the icon format chosen by the manufacturer/OS.

Steps to reproduce

  1. Just install Brave

Actual result

The icon does not have any shape
noshape

Expected result

The icon should follow the shape chosen by the system/launcher.
Credits for this adaptive icon by Fluidity Adaptive Icon Pack
adaptive

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

1.23.31

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional information

More info about adaptive icons: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive

@rodrigoswz rodrigoswz added the OS/Android Fixes related to Android browser functionality label Mar 12, 2021
@srirambv srirambv added design A design change, especially one which needs input from the design team misc/icons labels Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team misc/icons OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

2 participants