Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong corner rounding on "view site information" button #15484

Open
Darhagonable opened this issue Apr 24, 2021 · 0 comments
Open

Wrong corner rounding on "view site information" button #15484

Darhagonable opened this issue Apr 24, 2021 · 0 comments
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@Darhagonable
Copy link

Description

small nitpick but i noticed the button for "view site information" in the adress bar still has the default border radius from chrome instead of the more squared look the other buttons in brave has.

Steps to Reproduce

  1. Open brave browser
  2. Hover over the "view site information" button
  3. Notice the wrong border radius

Actual result:

image

Expected result:

to have the same border radius like the other buttons for example the Brave Shields button
image

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 1.23.73 Chromium: 90.0.4430.85 (Official Build) (64-bit)
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Version/Channel Information:

I'm only running the current release so can't check the other versions but i haven't found anything here indicating that it has been changed in the other versions

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. design A design change, especially one which needs input from the design team labels May 3, 2021
@rebron rebron added this to To do - Buttons in Design System via automation May 3, 2021
@rebron rebron added this to P5 backlog in Front End May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Design System
To do - Buttons
Status: P5 backlog
Front End
  
P5 backlog
Development

No branches or pull requests

2 participants