Use a scoped class for the host resolver in CNAME uncloaking tests #15619
Labels
dev-concern
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA/No
release-notes/exclude
tests
Followup as per brave/brave-core#8601 (comment):
The CNAME tests in
browser/brave_shields/ad_block_service_browsertest.cc
usebrave::SetAdblockCnameHostResolverForTesting
, which needs to be manually reset to anullptr
after each test that uses it. This is an extra level of cognitive overhead when writing test code, so it'd be better to use a similar "scoped" class that will automatically reset when its destructor is called.The text was updated successfully, but these errors were encountered: