Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle failed wallet creation #17069

Open
bbondy opened this issue Jul 21, 2021 · 1 comment
Open

Handle failed wallet creation #17069

bbondy opened this issue Jul 21, 2021 · 1 comment
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@bbondy
Copy link
Member

bbondy commented Jul 21, 2021 •
edited

https://github.com/brave/brave-core/pull/8880/files/9e5e0fd68fb6d26f4910fbac25847c51cd3d1e42#diff-c9ee2d5dd5a0e2cce34c6ab621d3d221250c532b8a26e8245d37325d3701071a

We should have some error handling that checks for empty string and gives an error.
@bbondy bbondy added dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 21, 2021
@bbondy bbondy added this to Untriaged in Wallet via automation Jul 21, 2021
This was referenced Jul 21, 2021
Merged
Merged
@bbondy bbondy moved this from Untriaged to Backlog (MVP) in Wallet Jul 21, 2021
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 21, 2021
@bbondy
Copy link
Member Author

bbondy commented Jul 22, 2021

@jamesmudgett when one of these 2 buttons are pressed, the wallet creation happens. How would you like to display an error for that case?

Screen Shot 2021-07-21 at 8 02 31 PM

@bbondy bbondy moved this from Backlog (MVP) to Backlog in Wallet Sep 9, 2021
@bbondy bbondy added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 29, 2021
@bbondy bbondy moved this from Backlog to Needs more info in Wallet Nov 3, 2021
@bbondy bbondy moved this from Needs more info to Backlog in Wallet Nov 3, 2021
@bbondy bbondy moved this from Backlog to Backlog (Desktop Front End) in Wallet Dec 21, 2021
@bbondy bbondy removed this from Backlog (Desktop Front End) in Wallet Mar 16, 2022
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbondy